Re: mdclose() does not cope w/ FileClose() failure

From: Noah Misch <noah(at)leadboat(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: mdclose() does not cope w/ FileClose() failure
Date: 2019-12-22 20:47:24
Message-ID: 20191222204724.GB1280238@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 23, 2019 at 09:33:29AM +1300, Thomas Munro wrote:
> On Sun, Dec 22, 2019 at 10:19 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
> > Assert(segno == reln->md_num_open_segs[forknum]);
> > _fdvec_resize(reln, forknum, segno + 1);
>
> Oh yeah, I spotted that part too but didn't follow up.
>
> https://www.postgresql.org/message-id/flat/CA%2BhUKG%2BNBw%2BuSzxF1os-SO6gUuw%3DcqO5DAybk6KnHKzgGvxhxA%40mail.gmail.com

That patch of yours looks good.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-12-22 21:51:15 Re: unsupportable composite type partition keys
Previous Message Thomas Munro 2019-12-22 20:33:29 Re: mdclose() does not cope w/ FileClose() failure