Re: pg_control_init() bug

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Bossart, Nathan" <bossartn(at)amazon(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_control_init() bug
Date: 2019-12-21 20:42:27
Message-ID: 20191221204227.GK11527@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 10, 2019 at 05:46:48PM -0500, Tom Lane wrote:
> "Bossart, Nathan" <bossartn(at)amazon(dot)com> writes:
> > I noticed that pg_control_init() is failing an assertion on 13devel:
>
> Hmm, yeah. In a non-assert build I get
>
> regression=# select * from pg_control_init();
> ERROR: function return row and query-specified return row do not match
> DETAIL: Returned row contains 12 attributes, but query expects 11.
>
> > The attached patch seems to clear this up. I think this was missed in
> > 2e4db241.
>
> Evidently. Thanks for the report!

FYI, this has been applied:

Fix tuple column count in pg_control_init().

Oversight in commit 2e4db241b.

Nathan Bossart

Discussion: https://postgr.es/m/1B616360-396A-4482-AA28-375566C86160@amazon.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8729fa72483f8a9acf299508bb2cbae1aa9a29b8

Modified Files
--------------
src/backend/utils/misc/pg_controldata.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikolay Samokhvalov 2019-12-21 20:45:05 Re: [PATCH] Increase the maximum value track_activity_query_size
Previous Message Tom Lane 2019-12-21 20:42:21 Re: psql small improvement patch