From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | exclusion(at)gmail(dot)com |
Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-bugs(at)lists(dot)postgresql(dot)org |
Subject: | Re: BUG #16161: pg_ctl stop fails sometimes (on Windows) |
Date: | 2019-12-20 03:32:37 |
Message-ID: | 20191220.123237.432497214732463092.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
At Fri, 20 Dec 2019 05:40:00 +0300, Alexander Lakhin <exclusion(at)gmail(dot)com> wrote in
> 19.12.2019 23:09, Tom Lane wrote:
> > Alexander Lakhin <exclusion(at)gmail(dot)com> writes:
> >> Maybe we should change the condition to 'if (stat(fileName, &st) != 0 &&
> >> (err = GetLastError()) == ERROR_ACCESS_DENIED)' to avoid unnecessary
> >> sleep with a loop iteration...
> > Well, we have to loop back on file-not-found too ...
> I think, if the file is not found on stat() we can safely return the
> updated err (set errno with _dosmapper(err), to be exact). If we'll loop
> back, we'll get the same err = GetLastError() after next CreateFile().
I think Tom is mentinoing for O_CREAT case. If CreateFile returned
ERROR_ACCESS_DENIED, then stat() returns ERROR_FILE_NOT_FOUND, it
means the next CreateFile can success.
> >> It seems that the check for ERROR_DELETE_PENDING was added to
> >> pgwin32_safestat() blindly, the issue wasn't reproduced at that time:
> >> https://www.postgresql.org/message-id/CAB7nPqRJV6trFta-Qzgi6j2feuYR2ZC%2BKHvWdHnbpDG2scTrxw%40mail.gmail.com
> > Hmm, makes one wonder whether that's actually live code.
> I'll try to research this matter meantime.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Zubiri | 2019-12-20 03:46:34 | psql: Buggy interactions with wraparound in maximized gnome terminals. |
Previous Message | Kyotaro Horiguchi | 2019-12-20 03:29:28 | Re: BUG #16161: pg_ctl stop fails sometimes (on Windows) |