| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: non-exclusive backup cleanup is mildly broken |
| Date: | 2019-12-19 07:13:08 |
| Message-ID: | 20191219071308.GA45286@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 18, 2019 at 07:43:43AM -0500, Robert Haas wrote:
> On Tue, Dec 17, 2019 at 11:36 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> If pg_abort_backup callback function can be called safely even when
>> the backup is not in progress, we can just use the global variable like
>> pg_abort_backup_registered to register the callback function only
>> on first call. In this way, cancel_before_shmem_exit() doesn't need to
>> search the array to get rid of the function.
>
> Right. That's how the proposed patch works.
Well, it seems like I am a poor lonesome cowboy on this one then.
And what you are proposing does not break things either as far as I
checked, so I'll just go hide in a corner :)
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-12-19 07:31:05 | Re: automating pg_config.h.win32 maintenance |
| Previous Message | Amit Kapila | 2019-12-19 06:29:29 | Re: logical decoding : exceeded maxAllocatedDescs for .spill files |