| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: automating pg_config.h.win32 maintenance |
| Date: | 2019-12-19 03:59:24 |
| Message-ID: | 20191219035924.GE4202@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 17, 2019 at 11:56:17AM +0100, Peter Eisentraut wrote:
> Yeah, good idea. Attached patch is refactored so all three header files
> managed by AC_CONFIG_HEADERS are processed the same way.
Looks good. I just have one comment.
+ # XXX
+ open(my $f, '>>', 'src/include/pg_config.h')
+ || confess "Could not write to src/include/pg_config.h\n";
+ print $f "\n";
+ print $f "#define VAL_CONFIGURE \""
+ . $self->GetFakeConfigure() . "\"\n";
+ close($f);
This part needs a comment. Like it is the equivalent of what
src/common/'s Makefile does or something like that?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2019-12-19 04:46:33 | Re: Clean up some old cruft related to Windows |
| Previous Message | Mark Dilger | 2019-12-19 03:19:20 | Re: Read Uncommitted regression test coverage |