| From: | "Karl O(dot) Pinc" <kop(at)meme(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Marko Tiikkaja <marko(at)joh(dot)to>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: proposal: minscale, rtrim, btrim functions for numeric |
| Date: | 2019-12-10 12:56:33 |
| Message-ID: | 20191210065633.333b36e2@slate.karlpinc.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 10 Dec 2019 07:11:59 +0100
Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> út 10. 12. 2019 v 0:03 odesílatel Karl O. Pinc <kop(at)meme(dot)com> napsal:
> > I also wonder whether all the trim_scale() tests
> > are now necessary, but not enough to make any suggestions.
> I don't think so tests should be minimalistic - there can be some
> redundancy to coverage some less probable size effects of some future
> changes. More - there is a small symmetry with min_scale tests - and
> third argument - some times I use tests (result part) as
> "documentation".
Fine with me.
Tests pass against HEAD. Docs build and look good.
Patch looks good to me.
I'm marking it ready for a committer.
Thanks for the work.
Regards,
Karl <kop(at)meme(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ibrar Ahmed | 2019-12-10 13:06:19 | Re: BufFileRead() error signalling |
| Previous Message | Peter Eisentraut | 2019-12-10 12:41:28 | Re: about allow_system_table_mods and SET STATISTICS |