| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Failure in TAP tests of pg_ctl on Windows with parallel instance set |
| Date: | 2019-12-03 04:03:01 |
| Message-ID: | 20191203040301.GC1634@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 02, 2019 at 07:57:31AM -0500, Andrew Dunstan wrote:
> Looks reasonable.
Thanks, committed and back-patched down to 11, which is where we have
PostgresNode::get_free_port. This could go further down with more
refactoring of PostgresNode.pm but as it took a long time to find this
issue that does not seem really worth the extra legwork.
> I wonder if there are other test sets where we need to set the port.
I looked at that before sending the first email, with the tests of
initdb and pg_basebackup potentially breaking stuff, but we never
initialize (direct initdb) and then start a node without
PostgresNode.pm. So we are fine as far as I saw.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2019-12-03 04:13:43 | Re: Bogus EXPLAIN results with column aliases for mismatched partitions |
| Previous Message | Michael Paquier | 2019-12-03 03:53:23 | Re: Update minimum SSL version |