Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures
Date: 2019-11-27 03:59:55
Message-ID: 20191127035955.GI5435@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Nov 26, 2019 at 09:36:50PM -0500, Andrew Dunstan wrote:
> So I'm a bit stuck. Probably the best thing to do for now is revert the
> patch and mark the tests that need it in the libpq-sslpassword patch as
> TODO (with todo_skip). If somebody whose perl-fu is greater than mine
> can disentangle this mess that would be nice :-)

A revert sounds fine to me at this point. Some buildfarm animals are
not reporting back :(
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Etsuro Fujita 2019-11-27 07:15:25 pgsql: Fix typo in comment.
Previous Message Andrew Dunstan 2019-11-27 02:36:50 Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures