From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
---|---|
To: | Ranier Vilela <ranier_gyn(at)hotmail(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Tiny optmization or is a bug? |
Date: | 2019-11-22 22:14:52 |
Message-ID: | 20191122221452.lvos246pyygacean@development |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Nov 22, 2019 at 09:51:50PM +0000, Ranier Vilela wrote:
>Hi,
>Maybe this is a real bug.
>
>The assignment has no effect, or forget dereferencing it?
>
>Best regards.
>Ranier Vilela
>
>--- \dll\postgresql-12.0\a\backend\commands\lockcmds.c Mon Sep 30 17:06:55 2019
>+++ lockcmds.c Fri Nov 22 18:45:01 2019
>@@ -285,7 +285,7 @@
>
> LockViewRecurse_walker((Node *) viewquery, &context);
>
>- ancestor_views = list_delete_oid(ancestor_views, reloid);
>+ list_delete_oid(ancestor_views, reloid);
>
> table_close(view, NoLock);
> }
This was already reworked in the master branch by commit d97b714a219.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tels | 2019-11-22 22:15:29 | Re: backup manifests |
Previous Message | Ranier Vilela | 2019-11-22 22:10:29 | RE: [PATCH] Tiny optmization. |