| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Antonin Houska <ah(at)cybertec(dot)at>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Attempt to consolidate reading of XLOG page |
| Date: | 2019-11-22 13:40:07 |
| Message-ID: | 20191122134007.GA180646@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 22, 2019 at 10:35:51AM -0300, Alvaro Herrera wrote:
> FWIW I think the new code is buggy because it doesn't seem to be setting
> ws_off, so I suppose the optimization in ReadPageInternal to skip
> reading the page when it's already the page we have is not hit, except
> for the first page in the segment. I didn't verify this, just my
> impression while reading the code.
FWIW, this matches with my impression here, third paragraph:
https://www.postgresql.org/message-id/20191120083802.GB47145@paquier.xyz
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Khandekar | 2019-11-22 14:08:20 | Re: logical decoding : exceeded maxAllocatedDescs for .spill files |
| Previous Message | Alvaro Herrera | 2019-11-22 13:35:51 | Re: Attempt to consolidate reading of XLOG page |