| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Antonin Houska <ah(at)cybertec(dot)at>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Attempt to consolidate reading of XLOG page |
| Date: | 2019-11-22 07:11:23 |
| Message-ID: | 20191122071123.GC42684@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 22, 2019 at 12:49:33AM -0300, Alvaro Herrera wrote:
> Yes :-) hopefully next week. Thanks for reviewing.
Thanks, I am switching the entry as ready for committer then. Please
note that the latest patch series have a conflict at the top of
walsender.c easy enough to resolve, and that the function declaration
in xlogutils.h misses an "extern". I personally find unnecessary the
last sentence in the new comment block of xlogreader.h to describe the
new callback to open a segment about BasicOpenFile() and open()
because one could also use a transient file opened in the backend, but
I'll be fine with anything you think is most fit. That's a minor
point.
Thanks Antonin for doing the refactoring effort.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2019-11-22 07:28:32 | Re: Attempt to consolidate reading of XLOG page |
| Previous Message | Pavel Stehule | 2019-11-22 07:08:24 | Re: Why overhead of SPI is so large? |