Re: format of pg_upgrade loadable_libraries warning

On Thu, Nov 14, 2019 at 02:46:29PM -0500, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > On 2019-Oct-07, Bruce Momjian wrote:
> >> and the "in database" (which I have changed to capitalized "In database"
> >> in the attached patch), looks like:
> >> fprintf(script, "In database: %s\n", active_db->db_name);
> >> meaning it _isn't_ an output error message, but rather something that
> >> appears in an error file. I don't think either of these are translated.
> >> Is that wrong?
>
> > pg_fatal is a "gettext trigger" (see nls.mk), so that part of the
> > message is definitely translated.
>
> Right, but Bruce's point is that what goes into the separate output
> file listing problem cases is not translated, and never has been.
> Maybe we should start doing so, but that would be a distinct issue.
> I'm not really sure that we should translate it, anyway --- could
> there be anyone out there who is using tools to process these files?

Yes, we are lacking in all these output files so if we do one, we should
do them all.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +