| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Amit Langote <amitlangote09(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Dent John <denty(at)qqdd(dot)eu>, "Iwata, Aya" <iwata(dot)aya(at)jp(dot)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: [PATCH] use separate PartitionedRelOptions structure to store partitioned table options |
| Date: | 2019-11-12 04:50:03 |
| Message-ID: | 20191112045003.GJ1549@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 11, 2019 at 05:22:32PM +0300, Nikolay Shaplov wrote:
> Here goes v3 patch with the typo fixed
Still one here in v3 of the patch:
+ * Since there are no options for patitioned tables for now, we just do
+ * validation to report incorrect option error and leave.
It looks like you are having a hard time with partitioned tables.
+ if (validate)
+ parseRelOptions(reloptions, validate, RELOPT_KIND_PARTITIONED,
+ &numoptions);
We have been through great length to have build_reloptions, so
wouldn't it be better to also have this code path do so? Sure you
need to pass NULL for the parsing table.. But there is a point to
reduce the code paths using directly parseRelOptions() and the
follow-up, expected calls to allocate and to fill in the set of
reloptions.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-11-12 04:54:32 | Re: Add SQL function to show total block numbers in the relation |
| Previous Message | imai.yoshikazu@fujitsu.com | 2019-11-12 04:41:54 | RE: Planning counters in pg_stat_statements (using pgss_store) |