| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: pg_waldump and PREPARE |
| Date: | 2019-11-11 07:16:02 |
| Message-ID: | 20191111071602.GA1418@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 11, 2019 at 01:21:28PM +0900, Fujii Masao wrote:
> Thanks for the review! You are right.
> I fixed this issue in the attached patch.
The proposed format looks fine to me. I have just one comment. All
three callers of standby_desc_invalidations() don't actually need to
print any data if there are zero messages, so you can simplify a bit
xact_desc_commit() and xact_desc_prepare() regarding the check on
parsed.nmsgs, no?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2019-11-11 07:29:09 | Re: cost based vacuum (parallel) |
| Previous Message | Masahiko Sawada | 2019-11-11 06:55:39 | Re: [HACKERS] Block level parallel vacuum |