Re: v12 and pg_restore -f-

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "imai(dot)yoshikazu(at)fujitsu(dot)com" <imai(dot)yoshikazu(at)fujitsu(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: v12 and pg_restore -f-
Date: 2019-11-05 15:00:35
Message-ID: 20191105150035.GN6962@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Greetings,

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Stephen Frost <sfrost(at)snowman(dot)net> writes:
> > * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> >> In this case, not in the least: we would simply be imposing the sort
> >> of *orderly* feature introduction that I thought was the plan from
> >> the very beginning [1]. That is, first make "-f -" available, and
> >> make it required only in some later version. If we'd back-patched
> >> the optional feature back in April, it might've been okay to require
> >> it in v12, but we failed to provide any transition period.
>
> > ... just like we didn't provide any transistion period for the
> > recovery.conf changes.
>
> Sure, because there wasn't any practical way to provide a transition
> period. I think that case is entirely not comparable to this one,
> either as to whether a transition period is possible, or as to whether
> the benefits of the change merit forced breakage.

We didn't put any effort into trying to provide a transition period, and
for good reason- everyone gets 5 years of transition time. I'd be just
as happy to not even commit the change to make -f- go to stdout in the
back-branches, if I didn't feel that the behavior of it going to a file
called ./- was really just an outright bug in the first place.

Thanks,

Stephen

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Adrian Klaver 2019-11-05 15:01:37 Re: select view definition from pg_views feature request
Previous Message Softwarelimits 2019-11-05 14:56:26 How to import Apache parquet files?

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-11-05 15:02:31 Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status)
Previous Message Tom Lane 2019-11-05 14:46:00 Re: v12 and pg_restore -f-