Re: v12 and pg_restore -f-

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "imai(dot)yoshikazu(at)fujitsu(dot)com" <imai(dot)yoshikazu(at)fujitsu(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: v12 and pg_restore -f-
Date: 2019-11-05 14:38:12
Message-ID: 20191105143812.GM6962@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Greetings,

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> In this case, not in the least: we would simply be imposing the sort
> of *orderly* feature introduction that I thought was the plan from
> the very beginning [1]. That is, first make "-f -" available, and
> make it required only in some later version. If we'd back-patched
> the optional feature back in April, it might've been okay to require
> it in v12, but we failed to provide any transition period.

... just like we didn't provide any transistion period for the
recovery.conf changes.

> I'm in favor of making v12 act like the older branches now do, and
> requiring "-f -" only as of v13. Yeah, the transition will be a
> little slower, but this feature is not of such huge value that it
> really justifies breaking scripts with zero notice.

The recovery.conf changes provided absolutely zero value in this
release and breaks a great deal more things.

This argument simply doesn't hold with what we've done historically or
even in this release, so, no, I don't agree that it makes sense to
revert this change any more than it makes sense to revert the
recovery.conf changes. Maybe, if this had come up over the summer and
this agreement came out that these changes weren't worth the breakage
that they cause, we could have reverted them, but that ship has sailed
at this point.

Thanks,

Stephen

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Bibi Mansione 2019-11-05 14:42:17 Hunspell as filtering dictionary
Previous Message Stephen Frost 2019-11-05 14:34:45 Re: v12 and pg_restore -f-

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-11-05 14:46:00 Re: v12 and pg_restore -f-
Previous Message Stephen Frost 2019-11-05 14:34:45 Re: v12 and pg_restore -f-