Re: wal_sender_timeout / wal_receiver_timeout - seconds or milliseconds?

On Thu, Oct 24, 2019 at 01:06:45PM +0000, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/12/runtime-config-replication.html
> Description:
>
> Dear sir or madam!
>
> The documentation about the parameter wal_sender_timeout refers to an
> integer value in milliseconds in the first sentence. Reading up to the
> default value in the paragraph, it is set to 60 seconds. The same difference
> of milliseconds and seconds is included in postgresql.conf:
>
> #wal_sender_timeout = 60s # in milliseconds; 0 disables
>
> This difference is found in the documentation and postgresql.conf for
> parameter wal_receiver_timeout, too.
>
> #wal_receiver_timeout = 60s # time that receiver waits for
> # communication from master
> # in milliseconds; 0 disables
>
> Please check and verify. - Thank you!

The default _value_ is 60 seconds, and we use the 's' to specify
seconds. What the comment is saying is that if you _don't_ specify any
units, the integer is in milliseconds. I am not sure how to improve
that.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +