| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Hsu, John" <hsuchen(at)amazon(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: Include RELKIND_TOASTVALUE in get_relkind_objtype |
| Date: | 2019-11-05 02:29:02 |
| Message-ID: | 20191105022902.GE16867@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 04, 2019 at 03:31:27PM -0500, Tom Lane wrote:
> I'd rather do something like the attached, which makes it more of an
> explicit goal that we won't fail on bad input. (As written, we'd only
> fail on bad classId, which is a case that really shouldn't happen.)
Okay, that part looks fine.
> Tests are the same as yours, but I revised the commentary and got
> rid of the elog-for-bad-relkind.
No objections on that part either.
> I also made some cosmetic changes in commands/alter.c, so as to (1)
> make it clear by inspection that those calls are only used to feed
> aclcheck_error, and (2) avoid uselessly computing a value that we
> won't need in normal non-error cases.
Makes also sense. Thanks for looking at it!
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2019-11-05 02:48:19 | Re: PostgreSQL 12 installation fails because locale name contained non-english characters |
| Previous Message | Michael Paquier | 2019-11-05 02:18:00 | Re: Do we have a CF manager for November? |