| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Nikolay Shaplov <dhyan(at)nataraj(dot)su>, Dent John <denty(at)qqdd(dot)eu>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Iwata, Aya" <iwata(dot)aya(at)jp(dot)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Do not use StdRdOptions in Access Methods |
| Date: | 2019-11-05 00:22:20 |
| Message-ID: | 20191105002220.GA16867@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 31, 2019 at 05:55:55PM +0900, Michael Paquier wrote:
> Thanks. I exactly did the same thing on my local branch.
Hearing nothing more, I have done some adjustments to the patch and
committed it. Please note that I have not switched the old interface
to be static to reloptions.c as if you look closely at reloptions.h we
allow much more flexibility around HANDLE_INT_RELOPTION to fill and
parse the reloptions in custom AM. AM maintainers had better use the
new interface, but there could be a point for more customized error
messages.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Quan Zongliang | 2019-11-05 00:37:17 | Re: Restore replication settings when modifying a field type |
| Previous Message | Thomas Munro | 2019-11-05 00:20:20 | Re: Backport "WITH ... AS MATERIALIZED" syntax to <12? |