| From: | Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: pg_waldump erroneously outputs newline for FPWs, and another minor bug |
| Date: | 2019-11-04 11:42:35 |
| Message-ID: | 20191104124235.02df2198@firost |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 30 Oct 2019 09:26:21 +0900
Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Oct 29, 2019 at 04:42:07PM -0700, Peter Geoghegan wrote:
> > The same commit from Heikki omitted one field from that record, for no
> > good reason. I backpatched a bugfix to the output format for nbtree
> > page splits a few weeks ago, fixing that problem. I agree that we
> > should also backpatch this bugfix.
>
> The output format of pg_waldump may matter for some tools, like
> Jehan-Guillaume's PAF [1], but I am ready to bet that any tools like
> that just skip any noise newlines, so +1 for a backpatch.
>
> I am adding Jehan-Guillaume in CC just in case.
Thank you Michael!
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-11-04 11:51:57 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |
| Previous Message | Dagfinn Ilmari Mannsåker | 2019-11-04 11:30:23 | Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition |