| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Igor Calabria <igor(dot)calabria(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Adding percentile metrics to pg_stat_statements module |
| Date: | 2019-11-01 14:17:51 |
| Message-ID: | 20191101141751.6ixckomofyhejqws@development |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 01, 2019 at 11:11:13AM -0300, Igor Calabria wrote:
>Yeah, I agree that there's no reason to store the digests themselves and I
>really liked the idea of it being optional.
That's not what I wrote. My point was that we *should* store the digests
themselves, otherwise we just introduce additional errors into the
estimates, because it discards the weights/frequencies.
>If it turns out that memory consumption on real workloads is small enough,
>it could eventually be turned on by default.
>
Maybe, but it's not just about memory consumption. CPU matters too.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2019-11-01 14:41:19 | Re: Remove configure --disable-float4-byval and --disable-float8-byval |
| Previous Message | Igor Calabria | 2019-11-01 14:11:13 | Re: Adding percentile metrics to pg_stat_statements module |