| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, Nikolay Shaplov <dhyan(at)nataraj(dot)su>, Dent John <denty(at)qqdd(dot)eu>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Iwata, Aya" <iwata(dot)aya(at)jp(dot)fujitsu(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Do not use StdRdOptions in Access Methods |
| Date: | 2019-10-28 15:02:20 |
| Message-ID: | 20191028150220.GA18542@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Oct-23, Michael Paquier wrote:
> On Wed, Oct 23, 2019 at 11:16:25AM +0900, Amit Langote wrote:
> > IMO, parts of the patch that only refactors the existing code should
> > be first in the list as it is easier to review, especially if it adds
> > no new concepts. In this case, your patch to break StdRdOptions into
> > more manageable chunks would be easier to understand if it built upon
> > a simplified framework of parsing reloptions text arrays.
>
> Thanks for doing a split. This helps in proving the point that this
> portion has independent value.
Not a split, yes? AFAICS this code is nowhere in Nikolay's proposed
patchset -- it seems completely new development by Amit. Am I wrong?
I also think that this has value -- let's go for it. I think I'll be
back on Wednesday to review it, if you would prefer to wait.
Thanks
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shay Rojansky | 2019-10-28 15:02:30 | strpos behavior change around empty substring in PG12 |
| Previous Message | Mark Felder | 2019-10-28 15:00:12 | Re: jsonb_set() strictness considered harmful to data |