Re: pgsql: Make the order of the header file includes consistent in non-bac

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Amit Kapila <akapila(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Make the order of the header file includes consistent in non-bac
Date: 2019-10-25 03:17:02
Message-ID: 20191025031702.GD8671@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi Amit,

On Fri, Oct 25, 2019 at 02:24:50AM +0000, Amit Kapila wrote:
> Make the order of the header file includes consistent in non-backend modules.
>
> Similar to commit 7e735035f2, this commit makes the order of header file
> inclusion consistent for non-backend modules.
>
> In passing, fix the case where we were using angle brackets (<>) for the
> local module includes instead of quotes ("").

locust has just reported a build failure here:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=locust&dt=2019-10-25%2002%3A58%3A55

And the cause is visibly this portion of the commit:
--- a/src/interfaces/ecpg/pgtypeslib/dt_common.c
+++ b/src/interfaces/ecpg/pgtypeslib/dt_common.c
@@ -7,9 +7,9 @@
#include <math.h>

#include "common/string.h"
-#include "pgtypeslib_extern.h"
#include "dt.h"
#include "pgtypes_timestamp.h"
+#include "pgtypeslib_extern.h"
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2019-10-25 03:24:08 Re: pgsql: Make the order of the header file includes consistent in non-bac
Previous Message Amit Kapila 2019-10-25 02:24:50 pgsql: Make the order of the header file includes consistent in non-bac