Re: pgsql: Remove last traces of heap_open/close in the tree

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pgsql: Remove last traces of heap_open/close in the tree
Date: 2019-10-21 03:35:32
Message-ID: 20191021033532.GH1542@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sat, Oct 19, 2019 at 02:25:46AM +0000, Michael Paquier wrote:
> Remove last traces of heap_open/close in the tree
>
> Since pluggable storage has been introduced, those two routines have
> been replaced by table_open/close, with some compatibility macros still
> present to allow extensions to compile correctly with v12.
>
> Some code paths using the old routines still remained, so replace them.
> Based on the discussion done, the consensus reached is that it is better
> to remove those compatibility macros so as nothing new uses the old
> routines, so remove also the compatibility macros.
>
> Discussion: https://postgr.es/m/20191017014706.GF5605@paquier.xyz

This has been causing failures with redis_fdw:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2019-10-19%2016%3A47%3A35

Thanks Andrew for the fix!
https://github.com/pg-redis-fdw/redis_fdw/commit/2bfde6e56a7b4fe54ce3ee1f9b001bc75cadb60d
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2019-10-21 03:42:21 pgsql: Fix memory leak introduced in commit 7df159a620.
Previous Message Michael Paquier 2019-10-21 02:40:09 pgsql: Fix error reporting of connect_timeout in libpq for value parsin