Re: Remaining calls of heap_close/heap_open in the tree

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remaining calls of heap_close/heap_open in the tree
Date: 2019-10-17 09:58:27
Message-ID: 20191017095827.GA22713@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-Oct-17, Michael Paquier wrote:

> On Thu, Oct 17, 2019 at 01:04:50AM -0700, Andres Freund wrote:
> > Wonder if it's worth removing the backward compat ones from master? I
> > don't quite think so, but...
>
> I would vote for the removal so as we'll never see that again in
> core. Let's see what others think here.

Agreed. There are enough other API changes that if an external
extension wants to keep using heap_* in their code, they can add their
own defines anyway.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Madars Vitolins 2019-10-17 10:12:03 Memory leak reported by address sanitizer in ECPGconnect/CRYPTO_zalloc
Previous Message Alvaro Herrera 2019-10-17 09:56:48 Re: v12.0: segfault in reindex CONCURRENTLY