From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: dropping column prevented due to inherited index |
Date: | 2019-10-11 21:39:47 |
Message-ID: | 20191011213947.GA10170@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2019-Oct-11, Michael Paquier wrote:
> + if (!recursing)
> + {
> + /*
> + * The resursing lookup for inherited child relations is done. All
> + * the child relations have been scanned and the object addresses of
> + * all the columns to-be-dropped are registered in addrs, so drop.
> + */
> + performMultipleDeletions(addrs, behavior, 0);
> + free_object_addresses(addrs);
> + }
Typo "resursing". This comment seems a bit too long to me. Maybe
"Recursion having ended, drop everything that was collected." suffices.
(Fits in one line.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2019-10-11 21:49:49 | Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status) |
Previous Message | Tom Lane | 2019-10-11 21:13:04 | Re: stress test for parallel workers |