| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: dropping column prevented due to inherited index |
| Date: | 2019-10-10 04:13:37 |
| Message-ID: | 20191010041337.GE1852@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 09, 2019 at 06:36:35AM -0300, Alvaro Herrera wrote:
> Right, something like that. Needs a comment to explain what we do and
> how recursing=true correlates with addrs=NULL, I think. Maybe add an
> assert.
Yes, that would be a thing to do. So I have added more comments
regarding that aspect, an assertion, and more tests with a partitioned
table without any children, and an actual check that all columns have
been dropped in the leaves of the partition tree. How does that look?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| ATExecDropColumn-inh-recursion-fix_v4.patch | text/x-diff | 7.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2019-10-10 04:28:17 | Re: maintenance_work_mem used by Vacuum |
| Previous Message | Michael Paquier | 2019-10-10 03:56:35 | Re: pgsql: Remove pqsignal() from libpq's official exports list. |