| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: abort-time portal cleanup |
| Date: | 2019-10-08 18:10:41 |
| Message-ID: | 20191008181041.rjxv7afowfrz5ztk@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-10-07 12:14:52 -0400, Robert Haas wrote:
> > - if (portal->status == PORTAL_READY)
> > - MarkPortalFailed(portal);
> >
> > Why it is safe to remove this check? It has been explained in commit
> > 7981c342 why we need that check. I don't see any explanation in email
> > or patch which justifies this code removal. Is it because you removed
> > PortalCleanup? If so, that is still called from PortalDrop?
>
> All MarkPortalFailed() does is change the status to PORTAL_FAILED and
> call the cleanup hook. PortalDrop() calls the cleanup hook, and we
> don't need to change the status if we're removing it completely.
Note that currently PortalCleanup() behaves differently depending on
whether the portal is set to failed or not...
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2019-10-08 18:45:41 | Re: Transparent Data Encryption (TDE) and encrypted files |
| Previous Message | Stephen Frost | 2019-10-08 18:08:40 | Re: v12 and pg_restore -f- |