| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Skip recovery/standby signal files in pg_basebackup |
| Date: | 2019-09-30 07:21:38 |
| Message-ID: | 20190930072138.GN2888@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 27, 2019 at 02:52:54PM -0400, David Steele wrote:
> Restoring these files could cause surprising behaviors so it seems best
> to let the restore process create them when needed.
>
> Patch is attached.
When taking a base backup from a standby, we have always copied
recovery.conf if present, which would have triggered recovery (and
a standby if standby_mode was enabled). Hence always including
RECOVERY_SIGNAL_FILE would be consistent with the past behavior.
Including STANDBY_SIGNAL_FILE would be consistent with checking if
standby_mode was set or not in recovery.conf. We have replaced
standby_mode by the standby signal file, so including it if present
is consistent with the past as well, no?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-09-30 07:38:02 | Re: Batch insert in CTAS/MatView code |
| Previous Message | Paul Guo | 2019-09-30 07:07:48 | Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown) |