Re: pgsql: Make crash recovery ignore recovery target settings.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Fujii Masao <fujii(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Make crash recovery ignore recovery target settings.
Date: 2019-09-30 02:44:54
Message-ID: 20190930024454.GF2888@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi Fujii-san,

On Mon, Sep 30, 2019 at 01:21:00AM +0000, Fujii Masao wrote:
> Make crash recovery ignore recovery target settings.
>
> In v11 or before, recovery target settings could not take effect in
> crash recovery because they are specified in recovery.conf and
> crash recovery always starts without recovery.conf. But commit
> 2dedf4d9a8 integrated recovery.conf into postgresql.conf and
> which unexpectedly allowed recovery target settings to take effect
> even in crash recovery. This is definitely not good behavior.
>
> To fix the issue, this commit makes crash recovery always ignore
> recovery target settings.
>
> Back-patch to v12.

It would be nice to avoid committing stuff into REL_12_STABLE until
the version is tagged (not stamped!) as the tarball wrap for the GA of
this week is going to be soon.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2019-09-30 03:02:05 Re: pgsql: Make crash recovery ignore recovery target settings.
Previous Message Michael Paquier 2019-09-30 01:46:41 Re: pgsql: Add libpq parameter 'channel_binding'.