| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_wal/RECOVERYHISTORY file remains after archive recovery |
| Date: | 2019-09-30 01:10:12 |
| Message-ID: | 20190930011011.GB2888@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 27, 2019 at 10:00:16PM +0900, Masahiko Sawada wrote:
> I abandoned once to move the removal code to between
> writeTimeLineHistory() and timeline switching because of expanding the
> window but since unlink itself will complete within a very short time
> it would not be problamatic much.
>
> Attached the updated patch that just moves the removal code.
That's not quite it, as you forgot to move the declaration of
recoveryPath so the patch fails to compile.
Adding some tests would be nice, so I updated your patch to include
something. One place where we recover files from archives is
002_archiving.pl, still the files get renamed to the segment names
when recovered so that's difficult to make that part 100%
deterministic yet. Still as a reminder of the properties behind those
files it does not sound bad to document it in the test either, that's
cheap, and we get the future covered.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v4_remove_recovered_historyfile.patch | text/x-diff | 2.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-09-30 01:24:06 | Re: [DOC] Document concurrent index builds waiting on each other |
| Previous Message | Chapman Flack | 2019-09-30 00:13:32 | checking my understanding of TupleDesc |