From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru> |
Cc: | Paul Guo <pguo(at)pivotal(dot)io>, Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Jimmy Yih <jyih(at)pivotal(dot)io>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
Subject: | Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown) |
Date: | 2019-09-27 14:28:18 |
Message-ID: | 20190927142818.GA20414@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2019-Sep-27, Alexey Kondratov wrote:
> 1) Maybe I've missed it somewhere in the thread above, but currently
> pg_rewind allows to run itself with -R and --source-pgdata. In that case -R
> option is just swallowed and neither standby.signal, nor
> postgresql.auto.conf is written, which is reasonable though. Should it be
> stated somehow in the docs that -R option always has to go altogether with
> --source-server? Or should pg_rewind notify user that options are
> incompatible and no recovery configuration will be written?
Hmm I think it should throw an error, yeah. Ignoring options is not
good.
> + # Now, when pg_rewind apparently succeeded with minimal permissions,
> + # add REPLICATION privilege. So we could test that new standby
> + # is able to connect to the new master with generated config.
> + $node_standby->psql(
> + 'postgres', "ALTER ROLE rewind_user WITH REPLICATION;");
I think this better use safe_psql.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2019-09-27 14:35:47 | Re: abort-time portal cleanup |
Previous Message | Nikita Glukhov | 2019-09-27 14:25:54 | Re: Support for jsonpath .datetime() method |