Re: pg_wal/RECOVERYHISTORY file remains after archive recovery

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_wal/RECOVERYHISTORY file remains after archive recovery
Date: 2019-09-27 08:09:53
Message-ID: 20190927080953.GI8485@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 27, 2019 at 01:51:25PM +0900, Masahiko Sawada wrote:
> On Thu, Sep 26, 2019 at 6:23 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> What about moving the logic that removes RECO VERYXLOG and
>> RECOVERYHISTORY from exitArchiveRecovery() and performing it
>> just before/after RemoveNonParentXlogFiles()? Which looks simple.
>
> Agreed. Attached the updated patch.

Mea culpa here, I have just noticed the thread. Fujii-san, would you
prefer if I take care of it? And also, what's the issue with not
doing the removal of both files just after writeTimeLineHistory()?
That's actually what happened before cbc55da5.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2019-09-27 08:17:42 Re: Implementing Incremental View Maintenance
Previous Message Yuya Watari 2019-09-27 07:43:53 Re: Keep compiler silence (clang 10, implicit conversion from 'long' to 'double' )