Cleanup code related to OpenSSL <= 0.9.6 in fe/be-secure-openssl.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Cleanup code related to OpenSSL <= 0.9.6 in fe/be-secure-openssl.c
Date: 2019-09-27 03:23:11
Message-ID: 20190927032311.GB8485@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

While reviewing the area, I have bumped into the following bit in
fe-secure-openssl.c and be-secure-openssl.c:
- /* OpenSSL 0.96 does not support X509_V_FLAG_CRL_CHECK */
-#ifdef X509_V_FLAG_CRL_CHECK
[... stuff ...]

I think that this did not get removed because of the incorrect version
number in the comment, which should have been 0.9.6 from the start.

Anyway, let's clean up this code as per the attached. This set of
flags indeed exists since 0.9.7. Any thoughts or objections?
--
Michael

Attachment Content-Type Size
openssl-clean-crl-check.patch text/x-diff 1.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Paul Guo 2019-09-27 03:27:56 Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)
Previous Message Tatsuro Yamada 2019-09-27 03:18:17 Re: tab complete for explain SETTINGS