Re: pgsql: Support reloptions of enum type

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Support reloptions of enum type
Date: 2019-09-27 01:19:47
Message-ID: 20190927011947.GA10059@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hello, sorry I didn't notice this email.

On 2019-Sep-26, Michael Paquier wrote:

> This part from commit 773df88 is incorrect:

> + /*
> + * Set the default lock mode for this option. There is no actual way
> + * for a module to enforce it when declaring a custom relation option,
> + * so just use the highest level, which is safe for all cases.
> + */
> + newoption->lockmode = AccessExclusiveLock;

You're right, this was a merge blunder :-( Sorry about that.

> Do you mind if I apply the attached to fix the issue? Or perhaps you
> would prefer fixing the issue yourself? I noted some inconsistencies
> with the rest while on it (please see attached).

Thanks for fixing. It all looks correct to me.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-09-27 01:51:30 Re: pgsql: Support reloptions of enum type
Previous Message Michael Paquier 2019-09-27 00:32:23 Re: pgsql: Support reloptions of enum type