Re: Remove page-read callback from XLogReaderState.

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: hlinnaka(at)iki(dot)fi
Cc: andres(at)anarazel(dot)de, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Remove page-read callback from XLogReaderState.
Date: 2019-09-27 03:07:26
Message-ID: 20190927.120726.16966854.horikyota.ntt@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Wed, 25 Sep 2019 15:50:32 +0900 (Tokyo Standard Time), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in <20190925(dot)155032(dot)13779064(dot)horikyota(dot)ntt(at)gmail(dot)com>
> 709d003fbd hit this. Rebased.

Oops! I found a silly silent bug that it doesn't verify the first
page in new segments. Moreover it didin't load the first page in
a new loaded segment.

- Fixed a bug that it didn't load the first segment once new
loaded segment is loaded.

- Fixed a bug that it didn't verify the first segment if it is
not the target page.

Some fishy codes are reaminig but I'll post once the fixed
version.

regares.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
v8-0001-Move-callback-call-from-ReadPageInternal-to-XLogR.patch text/x-patch 27.3 KB
v8-0002-Move-page-reader-out-of-XLogReadRecord.patch text/x-patch 57.3 KB
v8-0003-Remove-globals-readSegNo-readOff-readLen.patch text/x-patch 8.2 KB
v8-0004-Change-policy-of-XLog-read-buffer-allocation.patch text/x-patch 6.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuro Yamada 2019-09-27 03:18:17 Re: tab complete for explain SETTINGS
Previous Message Yuya Watari 2019-09-27 03:00:15 Keep compiler silence (clang 10, implicit conversion from 'long' to 'double' )