Re: shared-memory based stats collector

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: alvherre(at)2ndquadrant(dot)com
Cc: thomas(dot)munro(at)gmail(dot)com, tomas(dot)vondra(at)2ndquadrant(dot)com, andres(at)anarazel(dot)de, a(dot)zakirov(at)postgrespro(dot)ru, ah(at)cybertec(dot)at, magnus(at)hagander(dot)net, robertmhaas(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: shared-memory based stats collector
Date: 2019-09-27 00:46:47
Message-ID: 20190927.094647.134825835.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Wed, 25 Sep 2019 18:01:02 -0300, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote in <20190925210102(dot)GA26396(at)alvherre(dot)pgsql>
> On 2019-Sep-10, Kyotaro Horiguchi wrote:
>
> > At Tue, 3 Sep 2019 18:28:05 -0400, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote in <20190903222805(dot)GA13932(at)alvherre(dot)pgsql>
> > > > Found a bug in initialization. StatsShememInit() was placed at a
> > > > wrong place and stats code on child processes accessed
> > > > uninitialized pointer. It is a leftover from the previous shape
> > > > where dsm was activated on postmaster.
> > >
> > > This doesn't apply anymore. Can you please rebase?
> >
> > Thanks! I forgot to post rebased version after doing. Here it is.
> >
> > - (Re)Rebased to the current master.
> > - Passed all tests for me.
>
> This seems to have very trivial conflicts -- please rebase again?

Affected by the code movement in 9a86f03b4e. Just
rebased. Thanks.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
v23-0001-sequential-scan-for-dshash.patch text/x-patch 10.6 KB
v23-0002-Add-conditional-lock-feature-to-dshash.patch text/x-patch 5.1 KB
v23-0003-Make-archiver-process-an-auxiliary-process.patch text/x-patch 11.9 KB
v23-0004-Shared-memory-based-stats-collector.patch text/x-patch 213.9 KB
v23-0005-Remove-the-GUC-stats_temp_directory.patch text/x-patch 10.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2019-09-27 00:59:19 Re: FETCH FIRST clause PERCENT option
Previous Message Michael Paquier 2019-09-27 00:37:26 Re: PostgreSQL12 and older versions of OpenSSL