| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Dent John <denty(at)qqdd(dot)eu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: [PATCH] src/test/modules/dummy_index -- way to test reloptions from inside of access method |
| Date: | 2019-09-24 15:38:30 |
| Message-ID: | 20190924153830.GA26314@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Sep-24, Nikolay Shaplov wrote:
> В письме от вторник, 24 сентября 2019 г. 9:25:54 MSK пользователь Alvaro
> Herrera написал:
>
> > 0003 looks useful, thanks for completing it. I think it would be a good
> > idea to test invalid values for each type of reloption too (passing
> > floating point to integers, strings to floating point, and so on).
>
> We already do it in reloption regression tests.
>
> My idea was to test here only the things that can't be tested in regression
> tests, on in real indexes like bloom.
I suppose that makes sense. But of course when I push enum reloptions
I will have to add such a test, since bloom does not have one.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-09-24 15:48:27 | Re: FETCH FIRST clause WITH TIES option |
| Previous Message | Antonin Houska | 2019-09-24 15:33:24 | Re: Attempt to consolidate reading of XLOG page |