Re: [PATCH] src/test/modules/dummy_index -- way to test reloptions from inside of access method

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Dent John <denty(at)qqdd(dot)eu>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: [PATCH] src/test/modules/dummy_index -- way to test reloptions from inside of access method
Date: 2019-09-24 02:39:52
Message-ID: 20190924023952.GG2012@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 20, 2019 at 08:58:27PM +0900, Michael Paquier wrote:
> I still need to do an extra pass on the code (particularly the AM
> part), but I think that we could commit that. Please note that I
> included the fix for the lockmode I sent today so as the patch can be
> tested:
> https://www.postgresql.org/message-id/20190920013831.GD1844@paquier.xyz

I looked at that over the last couple of days, and done as attached.
Well, the actual module is in 0003. I have added more comments to
document the basic AM calls so as it can easier be used as a template
for some other work, and tweaked a couple of things. 0001 and 0002
are just the patches from the other thread to address the issues with
the lock mode of custom reloptions.
--
Michael

Attachment Content-Type Size
v2-0001-Fix-failure-with-lock-mode-used-for-custom-relati.patch text/x-diff 2.9 KB
v2-0002-Allow-definition-of-lock-mode-for-custom-reloptio.patch text/x-diff 6.5 KB
v2-0003-Add-dummy_index_am-to-src-test-modules.patch text/x-diff 17.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2019-09-24 03:46:19 Re: PATCH: standby crashed when replay block which truncated in standby but failed to truncate in master node
Previous Message Amit Langote 2019-09-24 02:36:40 Re: Fix example in partitioning documentation