From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | James Coleman <jtc331(at)gmail(dot)com> |
Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pg_rewind docs correction |
Date: | 2019-09-18 01:41:41 |
Message-ID: | 20190918014141.GI8909@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Sep 17, 2019 at 08:38:18AM -0400, James Coleman wrote:
> I don't agree that that's a valid equivalency. I myself spent a lot of
> time trying to understand how this could possibly be true a while
> back, and even looked at source code to be certain. I've asked other
> people and found the same confusion.
>
> As I read it the 2nd second sentence doesn't actually tell you the
> differences; it makes a quick attempt at summarizing *how* the first
> sentence is true, but if the first sentence isn't accurate, then it's
> hard to read the 2nd one as helping.
Well, then it comes back to the part where I am used to the existing
docs :)
> If you'd prefer something less detailed at this point at that point in
> the docs, then something along the lines of "results in a data
> directory state which can then be safely replayed from the source" or
> some such.
Actually this is a good suggestion, and could replace the first
sentence of this paragraph.
> The docs shouldn't be correct just for someone how already understands
> the intricacies. And the end user shouldn't have to read the "how it
> works" (which incidentally is kinda hidden at the bottom underneath
> the CLI args -- perhaps we could move that?) to extrapolate things in
> the primary documentation.
Perhaps. This doc page is not that long either.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2019-09-18 01:50:22 | Re: [HACKERS] CLUSTER command progress monitor |
Previous Message | Michael Paquier | 2019-09-18 01:37:27 | Re: [HACKERS] [PATCH] pageinspect function to decode infomasks |