| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix progress reporting of CLUSTER / VACUUM FULL |
| Date: | 2019-09-13 18:52:41 |
| Message-ID: | 20190913185241.GA4516@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2019-Sep-13, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Fix progress reporting of CLUSTER / VACUUM FULL
>
> Not a new problem of this patch, exactly, but:
>
> /* Reindex options */
> #define REINDEXOPT_VERBOSE 1 << 0 /* print progress info */
> +#define REINDEXOPT_REPORT_PROGRESS 1 << 1 /* report pgstat progress */
>
> Surely these macro definitions are incredibly dangerous due to their
> lack of parentheses.
Ugh, I knew there was something odd here in the back of my mind but I
was unable to see what it was :-( I'll fix those definitions.
Thanks for looking,
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-09-13 19:30:30 | pgsql: Fix under-parenthesized macro definitions |
| Previous Message | Tom Lane | 2019-09-13 18:47:56 | Re: pgsql: Fix progress reporting of CLUSTER / VACUUM FULL |