From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | "Jamison, Kirk" <k(dot)jamison(at)jp(dot)fujitsu(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Adrien Nayrat <adrien(dot)nayrat(at)anayrat(dot)info> |
Subject: | Re: [PATCH] Speedup truncates of relation forks |
Date: | 2019-09-13 12:51:30 |
Message-ID: | 20190913125130.GA7078@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2019-Sep-13, Fujii Masao wrote:
> On Mon, Sep 9, 2019 at 3:52 PM Jamison, Kirk <k(dot)jamison(at)jp(dot)fujitsu(dot)com> wrote:
> > > Please add a preliminary patch that removes the function. Dead code is good,
> > > as long as it is gone. We can get it pushed ahead of the rest of this.
> >
> > Alright. I've attached a separate patch removing the smgrdounlinkfork.
>
> Per the past discussion, some people want to keep this "dead" function
> for some reasons. So, in my opinion, it's better to just enclose the function
> with #if NOT_USED and #endif, to keep the function itself as it is, and then
> to start new discussion on hackers about the removal of that separatedly
> from this patch.
I searched for anybody requesting to keep the function. I couldn't find
anything. Tom said in 2012:
https://www.postgresql.org/message-id/1471.1339106082@sss.pgh.pa.us
> As committed, the smgrdounlinkfork case is actually dead code; it's
> never called from anywhere. I left it in place just in case we want
> it someday.
but if no use has appeared in 7 years, I say it's time to kill it.
In absence of objections, I'll commit a patch to remove it later today.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2019-09-13 12:55:02 | Re: pgbench - allow to create partitioned tables |
Previous Message | Alvaro Herrera | 2019-09-13 12:46:57 | Re: psql - improve test coverage from 41% to 88% |