| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: psql - improve test coverage from 41% to 88% |
| Date: | 2019-09-13 03:17:46 |
| Message-ID: | 20190913031746.GB1735@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 12, 2019 at 12:14:16PM -0300, Alvaro Herrera wrote:
> Mostly, because I think they're going to cause trouble. Adding a
> parameter in the middle of the list may cause trouble for third-party
> users of TestLib. I propose that we make the routines a bit smarter to
> cope with the API change: use named parameters instead. And in order to
> do that without having to change existing users of command_check, make
> it so that the routine checks whether the parameter is a hashref, and
> behave differently. So when called as in the existing callsites (five
> scalar parameters) it behaves as currently.
+1.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2019-09-13 03:18:05 | Re: Berserk Autovacuum (let's save next Mandrill) |
| Previous Message | Peter Geoghegan | 2019-09-13 01:04:25 | Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index. |