| From: | Alvaro Herrera from 2ndQuadrant <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Useless code in RelationCacheInitializePhase3 |
| Date: | 2019-09-10 16:34:17 |
| Message-ID: | 20190910163417.GA5859@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
On 2019-Apr-13, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > I think it probably would work for catalog tables, as it's coded right
> > now. There's no catalog lookups RelationInitTableAccessMethod() for
> > tables that return true for IsCatalogTable(). In fact, I think we should
> > apply something like:
>
> Makes sense, and I'd also add some comments pointing out that there had
> better not be any catalog lookups when this is called for a system
> catalog.
I think this was forgotten ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-09-10 17:14:19 | another look at macOS SIP |
| Previous Message | Alvaro Herrera from 2ndQuadrant | 2019-09-10 16:05:29 | Re: Libpq support to connect to standby server as priority |