| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: Compiler warnings with MinGW |
| Date: | 2019-09-07 02:58:14 |
| Message-ID: | 20190907025814.GA684@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Sep 07, 2019 at 12:11:25AM +0200, Peter Eisentraut wrote:
> I'm not sure exactly what the upstream of mingw is these days, but I
> think the original issue that led to 811be893 has long been fixed [0],
> and the other stuff in mingwcompat.c is also no longer relevant [1]. I
> think mingwcompat.c could be removed altogether. I'm not sure to what
> extent we need to support 5+ year old mingw versions.
On HEAD I would not be against removing that as this leads to a
cleanup of our code. For MSVC, we only support VS 2013~ on HEAD, so
saying that we don't support MinGW older than what was proposed 5
years ago sounds sensible.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Swen Kooij | 2019-09-07 06:48:25 | Re: Patch to add hook to copydir() |
| Previous Message | Michael Paquier | 2019-09-07 02:52:43 | Re: pg_regress restart cluster? |