| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Plug-in common/logging.h with vacuumlo and oid2name |
| Date: | 2019-09-06 05:01:42 |
| Message-ID: | 20190906050142.GB1608@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 05, 2019 at 09:59:51AM -0400, Alvaro Herrera wrote:
> Patch looks good to me, please push.
Thanks, applied without the calls to set_pglocale_pgservice().
> Generally speaking I find the 'progname' handling a bit silly (since we
> have it both as a variable in each program and also in logging.c
> separately), but that's not the fault of this patch, and this patch
> doesn't make it worse. That said, I think some other messages in
> vacuumlo can be made pg_log_somelevel(), based on occurrences of
> 'progname'.
That would mean moving some of the messages from stdout to stderr. We
could do that.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2019-09-06 05:31:32 | Re: pg_promote() can cause busy loop |
| Previous Message | Michael Paquier | 2019-09-06 04:56:54 | Re: REINDEX filtering in the backend |