Re: pg_promote() can cause busy loop

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_promote() can cause busy loop
Date: 2019-09-05 02:09:35
Message-ID: 20190905020935.GA22147@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 05, 2019 at 10:53:19AM +0900, Fujii Masao wrote:
> It's ok to use PG_RETURN_BOOL(false) instead of breaking out of the loop
> in that case. Which would make the code simpler.

Okay. I would have done so FWIW.

> But I don't think it's worth warning about postmaster death here
> because a backend will emit FATAL message like "terminating connection
> due to unexpected postmaster exit" in secure_read() after
> pg_promote() returns false.

Good point, that could be equally confusing.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-09-05 02:12:13 Re: using explicit_bzero
Previous Message Michael Paquier 2019-09-05 02:07:25 Re: block-level incremental backup