Re: remove "msg" parameter from convert_tuples_by_name

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: remove "msg" parameter from convert_tuples_by_name
Date: 2019-09-03 18:52:01
Message-ID: 20190903185201.GA14872@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-Aug-07, Amit Langote wrote:

> If we're reducing the message string to occur only once in the source
> code, can we maybe write it to be more informative? I wonder if users
> aren't normally supposed to see this message?

Grepping for the messages given to convert_tuples_by_position yields
quite a few matches in regression test output, but none for the one in
convert_tuples_by_name. This makes me think that it isn't user-visible,
unless things go very wrong.

Pushed the patch, thanks.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pierre Ducroquet 2019-09-03 18:53:19 Re: [Patch] Invalid permission check in pg_stats for functional indexes
Previous Message Tom Lane 2019-09-03 18:42:54 Re: Change ereport level for QueuePartitionConstraintValidation