| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, movead li <movead(dot)li(at)highgo(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Rearranging ALTER TABLE to avoid multi-operations bugs |
| Date: | 2019-09-03 16:04:57 |
| Message-ID: | 20190903160457.GA15359@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Aug-01, Thomas Munro wrote:
> With my hacker hat: Hmm. I haven't looked at the patch, but not
> passing down the QueryEnvironment when recursing is probably my fault,
> and folding all such things into a new mechanism that would avoid such
> bugs in the future sounds like a reasonable approach, if potentially
> complicated to back-patch. I'm hoping to come back and look at this
> properly in a while.
Thomas: Any further input on this? If I understand you correctly,
you're not saying that there's anything wrong with Tom's patch, just
that you would like to do some further hacking afterwards.
Tom: CFbot says this patch doesn't apply anymore. Could you please
rebase? Also: There's further input from Movead; his proposed test
cases might be useful to add.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-09-03 16:21:37 | Re: Rearranging ALTER TABLE to avoid multi-operations bugs |
| Previous Message | Tom Lane | 2019-09-03 16:04:20 | Re: SIGQUIT on archiver child processes maybe not such a hot idea? |