Re: Patch to add hook to copydir()

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Swen Kooij <swenkooij(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Patch to add hook to copydir()
Date: 2019-09-02 20:06:11
Message-ID: 20190902200611.GA29494@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-Sep-02, Peter Eisentraut wrote:

> On 2019-09-02 20:54, Swen Kooij wrote:
> > I've been working on an extension that tightly integrates
> > postgres with underlying filesystem . I need to customize
> > how postgres copies directories for new databases.
>
> Could you share some more details, so we can assess whether that is a
> sensible way to go about it, and what other hooks might be needed?

It seems either terribly high-level, or terribly low-level, depending on
how you look at it. I wonder to what extent it conflicts with the table
AM work, and with the idea of allowing FDWs to have real relfilenodes.
I wonder if this is just one missing piece that's needed to complete
something of a layer for which other pieces are already satisfied by
other hooks.

As is and pending further explanation, it seems a bad idea to me. If we
want pluggability here, maybe we need some new abstraction layer.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Swen Kooij 2019-09-02 20:16:00 Re: Patch to add hook to copydir()
Previous Message Jonathan S. Katz 2019-09-02 19:55:04 Re: PG 12 draft release notes